Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

This commit is fixing the network-manager package detection (use dpkg-query instead of dpkg -l) #3

Closed
wants to merge 3 commits into from

Conversation

apatard
Copy link
Contributor

@apatard apatard commented Oct 22, 2012

Using dpkg-query -s is more appropriate than using dpkg -l and grep -q.
The only way to have 0 returned by dpkg-query -s is to have NM installed
and dpkg -l |grep -q may return 1 if the package is not yet known in the
base (for instance, right after installing).

Signed-off-by: Arnaud Patard apatard@hupstream.com

Using dpkg-query -s is more appropriate than using dpkg -l and grep -q.
The only way to have 0 returned by dpkg-query -s is to have NM installed
and dpkg -l |grep -q may return 1 if the package is not yet known in the
base (for instance, right after installing).

Signed-off-by: Arnaud Patard <apatard@hupstream.com>
@ghost ghost assigned szarkos Nov 12, 2012
@szarkos
Copy link
Contributor

szarkos commented Nov 12, 2012

Hello Arnaud! Apologies for the delay taking a look at this. I'm now working on this project and I'll be taking on these requests moving forward.

Thanks!
Steve

apatard added 2 commits April 9, 2013 16:22
Conflicts:
	waagent

Signed-off-by: Arnaud Patard <apatard@hupstream.com>
waagent is trying to detect if there's a virtual cdrom by grepping
fdisk output, except that the output is different if we're not using
en locale. Use LC_ALL=C to make sure we'll have "correct" output

Signed-off-by: Arnaud Patard <apatard@hupstream.com>
@szarkos szarkos closed this May 30, 2013
emsi referenced this pull request in hglkrijger/WALinuxAgent Jun 3, 2016
- correct scvmm references
- add unit tests for scvmm detection
- ensure all matching devices are mounted and examined for scvmm configuration
- exit once vmm startup script is found and executed
- fixes Azure#185
hglkrijger added a commit to hglkrijger/WALinuxAgent that referenced this pull request Jul 24, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants